New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite speaker note system #1232

Open

mgeisler opened this issue Sep 22, 2023 · 1 comment

Labels

good first issue help wanted

Collaborator

mgeisler commented Sep 22, 2023 •

edited

Loading

The speaker-notes.js file is a little home-grown system for injecting speaker notes to the pages.

I would like to rewrite this to use a more modern development style:

we should minimize the code when publishing the course
we should make the label ("Speaker Notes") translatable!
we could perhaps use a library for some of the state logic?
we could take advantage of Write mdbook renderer with strong templating system mdbook-i18n-helpers#70 when it's ready to do less on the fly DOM manipulation

The text was updated successfully, but these errors were encountered:

mgeisler added good first issue help wanted labels

elliotbrandwein mentioned this issue

Reset state to inline-open when speaker note popup is closed #1441

Merged

Collaborator Author

mgeisler commented Nov 2, 2023

Making the labels translatable is also being looked at in #1390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment