Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

section-index.html: code cleanup #1946

Closed
chalin opened this issue Apr 25, 2024 · 0 comments · Fixed by #1947
Closed

section-index.html: code cleanup #1946

chalin opened this issue Apr 25, 2024 · 0 comments · Fixed by #1947
Labels
cleanup/refactoring e0-minutes Effort < 60 min p2-medium

Comments

@chalin
Copy link
Collaborator

chalin commented Apr 25, 2024 •
edited
Loading

Originally posted by @chalin in #1890 (comment)

After looking at this more closely, it seems to make sense indeed.

Btw, the $parent variable is misnamed, because$parent is set to .Page.

Can we inline the variable instead?

Btw, IMHO .Page cannot be falsy, but .Page.File could be falsy. So the if condition can be simplified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup/refactoring e0-minutes Effort < 60 min p2-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

section-index.html code cleanup chalin/docsy
1 participant
@chalin