Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/go/sizes.go uses function from unsafe package but does not import it - fails to compile #4108

Closed
mvsestito opened this issue Dec 8, 2016 · 2 comments
Closed

/go/sizes.go uses function from unsafe package but does not import it - fails to compile #4108

mvsestito opened this issue Dec 8, 2016 · 2 comments

Comments

@mvsestito
Copy link

Source file /go/sizes.go line 50 attempts to call unsafe.Pointer but the file does not import the unsafe package.

https://github.com/google/flatbuffers/blob/master/go/sizes.go#L50

Offending commit:
b59aafc
@iamthebot
Copy link

iamthebot commented Dec 9, 2016 •
edited
Loading

@gwvo any chance the unsafe import line can be re-added? This latest commit is breaking automated builds across the board. Not sure how this got merged given the Travis CI test shows a failure. #4112 fixes this until #4111 is ready to go.

@rw
Copy link
Collaborator

rw commented Dec 9, 2016

Fixed

@rw rw closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rw @iamthebot @mvsestito