Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging UnitTest failed on x64 VS2015. Reason: Pointer format not consistent #134

Closed
flm8620 opened this issue Oct 26, 2016 · 0 comments
Closed

Comments

@flm8620
Copy link

flm8620 commented Oct 26, 2016

In logging_unittest.cc, we try to log a void* p = reinterpret_cast<void*>(0x12345678); in RAW_LOG(INFO, "ptr %p", p); format.
The golden file logging_unittest.err contains also a IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 0x12345678
When I build on x64 mode, outputs are:

Golden file string:

...
IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 12345678
...

Test generated string:

...
IDATE TIME__ THREADID logging_unittest.cc:LINE] RAW: ptr 0000000012345678
...

Which causes a fail.

By the way, diff command doesn't exist under Windows. Maybe test also for FC command, which gives a better experience for MSVC users.

@flm8620 flm8620 changed the title Loggine UnitTest failed on x64 VS2015. Reason: Pointer format not consistent Logging UnitTest failed on x64 VS2015. Reason: Pointer format not consistent Oct 26, 2016
@sergiud sergiud closed this as completed Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants