Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling 'Symbolize functionality' is not working #563

Closed
m-kurbanov opened this issue Jul 2, 2020 · 2 comments · Fixed by #620
Closed

Disabling 'Symbolize functionality' is not working #563

m-kurbanov opened this issue Jul 2, 2020 · 2 comments · Fixed by #620
Assignees
Labels
Milestone

Comments

@m-kurbanov
Copy link

From #523
cmake -DWITH_SYMBOLIZE=OFF is not working, because HAVE_SYMBOLIZE is defined in:

glog/src/utilities.h

Lines 130 to 141 in 0a2e593

#ifndef HAVE_SYMBOLIZE
// defined by gcc
#if defined(__ELF__) && defined(OS_LINUX)
# define HAVE_SYMBOLIZE
#elif defined(OS_MACOSX) && defined(HAVE_DLADDR)
// Use dladdr to symbolize.
# define HAVE_SYMBOLIZE
#elif defined(OS_WINDOWS)
// Use DbgHelp to symbolize
# define HAVE_SYMBOLIZE
#endif
#endif // !defined(HAVE_SYMBOLIZE)

@sergiud sergiud added the bug label Oct 3, 2020
@edbaunton
Copy link
Contributor

On what platform is this?

@m-kurbanov
Copy link
Author

platform: windows
But judging from the code it's true with all platforms

@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud self-assigned this Apr 7, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants