From 78484ceff2677faf8b4d94b73728a820035b0181 Mon Sep 17 00:00:00 2001 From: xppt Date: Tue, 2 Apr 2024 10:57:13 +0300 Subject: [PATCH] fix(symbolize): format unknown stack frames --- src/symbolize.cc | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/symbolize.cc b/src/symbolize.cc index 11a9872a0..6cb0e1222 100644 --- a/src/symbolize.cc +++ b/src/symbolize.cc @@ -642,18 +642,13 @@ OpenObjectFileContainingPcAndGetStartAddress(uint64_t pc, return nullptr; // Malformed line. } + strncpy(out_file_name, cursor, out_file_name_size); + // Making sure |out_file_name| is always null-terminated. + out_file_name[out_file_name_size - 1] = '\0'; + // Finally, "cursor" now points to file name of our interest. - FileDescriptor object_fd{ + return FileDescriptor{ FailureRetry([cursor] { return open(cursor, O_RDONLY); })}; - if (!object_fd) { - // Failed to open object file. Copy the object file name to - // |out_file_name|. - strncpy(out_file_name, cursor, out_file_name_size); - // Making sure |out_file_name| is always null-terminated. - out_file_name[out_file_name_size - 1] = '\0'; - return nullptr; - } - return object_fd; } }