From 1bfae38300bb43357d14050728fdc4834b29dbb9 Mon Sep 17 00:00:00 2001 From: Sergiu Deitsch Date: Wed, 9 Aug 2017 15:21:32 +0200 Subject: [PATCH] added missing exports (fixes #227) --- src/glog/logging.h.in | 3 ++- src/stacktrace.h | 3 ++- src/stacktrace_windows-inl.h | 1 - src/symbolize.h | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/glog/logging.h.in b/src/glog/logging.h.in index 35c65be7c..d97ab99c3 100644 --- a/src/glog/logging.h.in +++ b/src/glog/logging.h.in @@ -931,7 +931,8 @@ struct CompileAssert { struct CrashReason; // Returns true if FailureSignalHandler is installed. -bool IsFailureSignalHandlerInstalled(); +// Needs to be exported since it's used by the signalhandler_unittest. +GOOGLE_GLOG_DLL_DECL bool IsFailureSignalHandlerInstalled(); } // namespace glog_internal_namespace_ #define GOOGLE_GLOG_COMPILE_ASSERT(expr, msg) \ diff --git a/src/stacktrace.h b/src/stacktrace.h index 8c3e8fe8f..cb64b33a6 100644 --- a/src/stacktrace.h +++ b/src/stacktrace.h @@ -34,6 +34,7 @@ #define BASE_STACKTRACE_H_ #include "config.h" +#include "glog/logging.h" _START_GOOGLE_NAMESPACE_ @@ -53,7 +54,7 @@ _START_GOOGLE_NAMESPACE_ // .... ... // // "result" must not be NULL. -extern int GetStackTrace(void** result, int max_depth, int skip_count); +GOOGLE_GLOG_DLL_DECL int GetStackTrace(void** result, int max_depth, int skip_count); _END_GOOGLE_NAMESPACE_ diff --git a/src/stacktrace_windows-inl.h b/src/stacktrace_windows-inl.h index c747d96a3..726318879 100644 --- a/src/stacktrace_windows-inl.h +++ b/src/stacktrace_windows-inl.h @@ -38,7 +38,6 @@ _START_GOOGLE_NAMESPACE_ -GOOGLE_GLOG_DLL_DECL int GetStackTrace(void** result, int max_depth, int skip_count) { if (max_depth > 64) { max_depth = 64; diff --git a/src/symbolize.h b/src/symbolize.h index f61718424..86f0c792d 100644 --- a/src/symbolize.h +++ b/src/symbolize.h @@ -148,7 +148,7 @@ _START_GOOGLE_NAMESPACE_ // symbol name to "out". The symbol name is demangled if possible // (supports symbols generated by GCC 3.x or newer). Otherwise, // returns false. -bool Symbolize(void *pc, char *out, int out_size); +GOOGLE_GLOG_DLL_DECL bool Symbolize(void *pc, char *out, int out_size); _END_GOOGLE_NAMESPACE_