Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement delete manifest tests #915

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Jan 18, 2021

I was learning this repo to try to use in one personal thing and saw that some tests were pending to add.

This PR tries to implement the tests for crane.Delete, I'm not 100% if it is correct but it is a tryout 😄

if sounds reasonable I will try to implement the other missing tests

/cc @jonjohnsonjr

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, just a small style/consistency nit.

Thanks for this contribution! 🎉

pkg/crane/crane_test.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #915 (fc5c445) into master (38d292e) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   72.67%   72.41%   -0.27%     
==========================================
  Files         108      108              
  Lines        4696     4713      +17     
==========================================
  Hits         3413     3413              
- Misses        773      789      +16     
- Partials      510      511       +1     
Impacted Files Coverage Δ
pkg/registry/manifest.go 72.11% <0.00%> (-14.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d292e...9fbb727. Read the comment docs.

@cpanato cpanato force-pushed the delete_test branch 2 times, most recently from 31c4b55 to efe694e Compare January 18, 2021 15:03
pkg/crane/crane_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, otherwise lgtm.

pkg/registry/manifest.go Outdated Show resolved Hide resolved
@jonjohnsonjr
Copy link
Collaborator

if sounds reasonable I will try to implement the other missing tests

That would be wonderful, if you have the time! Thanks :)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants