From 591fd221aa2aa0cd68d9f4d964702e8c1ad35c48 Mon Sep 17 00:00:00 2001 From: Rahul Karmore Date: Fri, 28 Oct 2022 21:41:30 +0530 Subject: [PATCH 1/3] Add test case for JSON resource marshaling --- github/search_test.go | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/github/search_test.go b/github/search_test.go index c69c490445..18b53d60bd 100644 --- a/github/search_test.go +++ b/github/search_test.go @@ -914,3 +914,28 @@ func TestLabelsSearchResult_Marshal(t *testing.T) { testJSONMarshal(t, u, want) } +func TestCommitResult_Marshal(t *testing.T) { + testJSONMarshal(t, &CommitResult{}, "{}") + + c := &CommitResult{ + SHA: String("test"), + HTMLURL: String("hurl"), + CommentsURL: String("test curl"), + URL: String("test_url"), + Repository: &Repository{ID: Int64(1)}, + Score: Float64(1.1), + } + + want := `{ + "sha": "test", + "html_url": "hutl", + "comments_url": "test curl", + "url": "test_url", + "repository": { + "id": 1 + }, + "score":1.1 + }` + + testJSONMarshal(t, c, want) +} From 785c8e230eeb05b50a4047271d0b9c3d30e886eb Mon Sep 17 00:00:00 2001 From: Rahul Karmore Date: Fri, 28 Oct 2022 23:20:47 +0530 Subject: [PATCH 2/3] resolve test cases --- github/search_test.go | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/github/search_test.go b/github/search_test.go index 18b53d60bd..48b6527c8a 100644 --- a/github/search_test.go +++ b/github/search_test.go @@ -920,22 +920,35 @@ func TestCommitResult_Marshal(t *testing.T) { c := &CommitResult{ SHA: String("test"), HTMLURL: String("hurl"), - CommentsURL: String("test curl"), - URL: String("test_url"), + CommentsURL: String("curl"), + URL: String("url"), Repository: &Repository{ID: Int64(1)}, - Score: Float64(1.1), + Score: Float64(123), + Commit: &Commit{SHA: String("test")}, + Author: &User{ID: Int64(1)}, + Committer: &User{ID: Int64(1)}, + Parents: []*Commit{}, } want := `{ "sha": "test", - "html_url": "hutl", - "comments_url": "test curl", - "url": "test_url", + "commit": { + "sha": "test" + }, + "author": { + "id": 1 + }, + "committer": { + "id": 1 + }, + "html_url": "hurl", + "url": "url", + "comments_url": "curl", "repository": { - "id": 1 + "id": 1 }, - "score":1.1 - }` + "score": 123 + }` testJSONMarshal(t, c, want) } From 957b0eec177309ea00cc7ecd02478a8588abfd16 Mon Sep 17 00:00:00 2001 From: Rahul Karmore Date: Fri, 28 Oct 2022 23:31:02 +0530 Subject: [PATCH 3/3] add blank line --- github/search_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/github/search_test.go b/github/search_test.go index 48b6527c8a..b1973921cd 100644 --- a/github/search_test.go +++ b/github/search_test.go @@ -914,6 +914,7 @@ func TestLabelsSearchResult_Marshal(t *testing.T) { testJSONMarshal(t, u, want) } + func TestCommitResult_Marshal(t *testing.T) { testJSONMarshal(t, &CommitResult{}, "{}")