From 2bec3f1d6a93fcb690f01302286f25ea4929eeed Mon Sep 17 00:00:00 2001 From: abhijit-hota Date: Tue, 3 Oct 2023 10:09:49 +0530 Subject: [PATCH 1/3] init: add installation requests api --- github/apps.go | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/github/apps.go b/github/apps.go index ab83d59ab2..8965e66815 100644 --- a/github/apps.go +++ b/github/apps.go @@ -102,6 +102,15 @@ type InstallationPermissions struct { Workflows *string `json:"workflows,omitempty"` } +// InstallationRequest represents a pending GitHub App installation request. +type InstallationRequest struct { + ID *int64 `json:"id,omitempty"` + NodeID *string `json:"node_id,omitempty"` + Account *User `json:"account,omitempty"` + Requester *User `json:"requester,omitempty"` + CreatedAt *Timestamp `json:"created_at,omitempty"` +} + // Installation represents a GitHub Apps installation. type Installation struct { ID *int64 `json:"id,omitempty"` @@ -175,6 +184,29 @@ func (s *AppsService) Get(ctx context.Context, appSlug string) (*App, *Response, return app, resp, nil } +// ListInstallationRequests lists the pending installation requests that the current GitHub App has. +// +// GitHub API docs: https://docs.github.com/en/rest/apps/apps#list-installation-requests-for-the-authenticated-app +func (s *AppsService) ListInstallationRequests(ctx context.Context, opts *ListOptions) ([]*InstallationRequest, *Response, error) { + u, err := addOptions("app/installation-requests", opts) + if err != nil { + return nil, nil, err + } + + req, err := s.client.NewRequest("GET", u, nil) + if err != nil { + return nil, nil, err + } + + var i []*InstallationRequest + resp, err := s.client.Do(ctx, req, &i) + if err != nil { + return nil, resp, err + } + + return i, resp, nil +} + // ListInstallations lists the installations that the current GitHub App has. // // GitHub API docs: https://docs.github.com/en/rest/apps/apps#list-installations-for-the-authenticated-app From 0aea507166e29165b469f11d9333a7c8275d93d1 Mon Sep 17 00:00:00 2001 From: abhijit-hota Date: Tue, 3 Oct 2023 10:26:07 +0530 Subject: [PATCH 2/3] add test for API --- github/apps_test.go | 47 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/github/apps_test.go b/github/apps_test.go index f87d500687..a58326ea5e 100644 --- a/github/apps_test.go +++ b/github/apps_test.go @@ -72,6 +72,53 @@ func TestAppsService_Get_specifiedApp(t *testing.T) { } } +func TestAppsService_ListInstallationRequests(t *testing.T) { + client, mux, _, teardown := setup() + defer teardown() + + mux.HandleFunc("/app/installation-requests", func(w http.ResponseWriter, r *http.Request) { + testMethod(t, r, "GET") + testFormValues(t, r, values{ + "page": "1", + "per_page": "2", + }) + fmt.Fprint(w, `[{ + "id": 1, + "account": { "id": 2 }, + "requester": { "id": 3 }, + "created_at": "2018-01-01T00:00:00Z" + }]`, + ) + }) + + opt := &ListOptions{Page: 1, PerPage: 2} + ctx := context.Background() + installationRequests, _, err := client.Apps.ListInstallationRequests(ctx, opt) + if err != nil { + t.Errorf("Apps.ListInstallations returned error: %v", err) + } + + date := Timestamp{Time: time.Date(2018, time.January, 1, 0, 0, 0, 0, time.UTC)} + want := []*InstallationRequest{{ + ID: Int64(1), + Account: &User{ID: Int64(2)}, + Requester: &User{ID: Int64(3)}, + CreatedAt: &date, + }} + if !cmp.Equal(installationRequests, want) { + t.Errorf("Apps.ListInstallationRequests returned %+v, want %+v", installationRequests, want) + } + + const methodName = "ListInstallationRequests" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Apps.ListInstallationRequests(ctx, opt) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) +} + func TestAppsService_ListInstallations(t *testing.T) { client, mux, _, teardown := setup() defer teardown() From 3bc5b0bd54339b02ed393e97228075837d6702f2 Mon Sep 17 00:00:00 2001 From: abhijit-hota Date: Tue, 3 Oct 2023 10:38:41 +0530 Subject: [PATCH 3/3] fmt, lint, generate --- github/github-accessors.go | 40 ++++++++++++++++++++++++++++++ github/github-accessors_test.go | 44 +++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+) diff --git a/github/github-accessors.go b/github/github-accessors.go index b305bfc644..f34d9a4afd 100644 --- a/github/github-accessors.go +++ b/github/github-accessors.go @@ -8910,6 +8910,46 @@ func (i *InstallationRepositoriesEvent) GetSender() *User { return i.Sender } +// GetAccount returns the Account field. +func (i *InstallationRequest) GetAccount() *User { + if i == nil { + return nil + } + return i.Account +} + +// GetCreatedAt returns the CreatedAt field if it's non-nil, zero value otherwise. +func (i *InstallationRequest) GetCreatedAt() Timestamp { + if i == nil || i.CreatedAt == nil { + return Timestamp{} + } + return *i.CreatedAt +} + +// GetID returns the ID field if it's non-nil, zero value otherwise. +func (i *InstallationRequest) GetID() int64 { + if i == nil || i.ID == nil { + return 0 + } + return *i.ID +} + +// GetNodeID returns the NodeID field if it's non-nil, zero value otherwise. +func (i *InstallationRequest) GetNodeID() string { + if i == nil || i.NodeID == nil { + return "" + } + return *i.NodeID +} + +// GetRequester returns the Requester field. +func (i *InstallationRequest) GetRequester() *User { + if i == nil { + return nil + } + return i.Requester +} + // GetFrom returns the From field if it's non-nil, zero value otherwise. func (i *InstallationSlugChange) GetFrom() string { if i == nil || i.From == nil { diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go index 962e5e8f73..25c8ab7e4b 100644 --- a/github/github-accessors_test.go +++ b/github/github-accessors_test.go @@ -10487,6 +10487,50 @@ func TestInstallationRepositoriesEvent_GetSender(tt *testing.T) { i.GetSender() } +func TestInstallationRequest_GetAccount(tt *testing.T) { + i := &InstallationRequest{} + i.GetAccount() + i = nil + i.GetAccount() +} + +func TestInstallationRequest_GetCreatedAt(tt *testing.T) { + var zeroValue Timestamp + i := &InstallationRequest{CreatedAt: &zeroValue} + i.GetCreatedAt() + i = &InstallationRequest{} + i.GetCreatedAt() + i = nil + i.GetCreatedAt() +} + +func TestInstallationRequest_GetID(tt *testing.T) { + var zeroValue int64 + i := &InstallationRequest{ID: &zeroValue} + i.GetID() + i = &InstallationRequest{} + i.GetID() + i = nil + i.GetID() +} + +func TestInstallationRequest_GetNodeID(tt *testing.T) { + var zeroValue string + i := &InstallationRequest{NodeID: &zeroValue} + i.GetNodeID() + i = &InstallationRequest{} + i.GetNodeID() + i = nil + i.GetNodeID() +} + +func TestInstallationRequest_GetRequester(tt *testing.T) { + i := &InstallationRequest{} + i.GetRequester() + i = nil + i.GetRequester() +} + func TestInstallationSlugChange_GetFrom(tt *testing.T) { var zeroValue string i := &InstallationSlugChange{From: &zeroValue}