Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying functions fails on monorepo deps #1871

Closed
gino-m opened this issue Jun 26, 2024 · 3 comments · Fixed by #1872
Closed

Deploying functions fails on monorepo deps #1871

gino-m opened this issue Jun 26, 2024 · 3 comments · Fixed by #1872
Labels
type: bug Something isn't working

Comments

@gino-m
Copy link
Collaborator

gino-m commented Jun 26, 2024

Deploy fails with Cannot find module '@ground/proto'. This started happening after adding a dependency on @ground/proto to the functions package in #1821. The same happen when depending on @ground/lib.

@gino-m gino-m added the type: bug Something isn't working label Jun 26, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Jun 26, 2024

Things I've tried (unsuccessfully):

  • Referring to full path of index ('@ground/proto/dist/index')
  • Upgrading firebase-tools to latest version

It appears monorepos aren't supported by Firebase (firebase/firebase-tools#653), but it's unclear why the deploy was working when functions was only depending on lib, which is currently the case in master.

@gino-m
Copy link
Collaborator Author

gino-m commented Jun 26, 2024

but it's unclear why the deploy was working when functions was only depending on lib, which is currently the case in master.

Update: The deploy likely works because the only reference to @ground/lib is in tests.

@gino-m
Copy link
Collaborator Author

gino-m commented Jun 26, 2024

Using isolate-package as described here works for both root deploy and deploy from functions/. Sending a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant