Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add R8/Proguard keep-rules to JAR #1559

Closed
justcla opened this issue Aug 5, 2019 · 2 comments
Closed

Add R8/Proguard keep-rules to JAR #1559

justcla opened this issue Aug 5, 2019 · 2 comments
Labels
enhancement

Comments

@justcla
Copy link

justcla commented Aug 5, 2019

To help users with code shrinking, it would be useful to add keep-rules to the JAR.

Can you please add reliable keep-rules to the source?
e.g. in src/main/resources/META-INF/proguard/okhttp3.pro
@fardavide
Copy link

+1

@Marcono1234
Copy link
Collaborator

This has been implemented by #2397 and will be available in the next (not yet released) Gson version, probably 2.11.0.

However, this will require that you use @SerializedName on fields and ideally have a no-args constructor for you class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Marcono1234 @justcla @fardavide