Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP2: Model enum entries in annotation values #1861

Closed
ting-yuan opened this issue Apr 29, 2024 · 0 comments · Fixed by #1881
Closed

KSP2: Model enum entries in annotation values #1861

ting-yuan opened this issue Apr 29, 2024 · 0 comments · Fixed by #1881
Assignees
@neetopia
Labels
api API changes may be involved P1 major features or blocking bugs
Milestone
2.0

Comments

@ting-yuan
Copy link
Collaborator

Currently it is modeled as KSType. In KSP1, each enum entry has its own subtype, so users know which entry is passed.

In KSP2, all entries are of the same containing enum type and become indistinguishable. We either emulate the old behavior in KSP1, or model it differently.
@ting-yuan ting-yuan added P1 major features or blocking bugs api API changes may be involved labels Apr 29, 2024
@ting-yuan ting-yuan added this to the 2.0 milestone Apr 29, 2024
@neetopia neetopia self-assigned this May 7, 2024
@neetopia neetopia mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
api API changes may be involved P1 major features or blocking bugs
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. neetopia/ksp
2 participants
@ting-yuan @neetopia