Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: start testing against Node 10 #69

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Conversation

ofrobots
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2018
@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #69   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         111    111           
  Branches       22     22           
=====================================
  Hits          111    111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58270be...821e787. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

Can we just replace 9 with 10?

@ofrobots
Copy link
Contributor Author

No pressing need to stop testing against 9 (or 4). It aint hurting anything.

@ofrobots ofrobots merged commit fa311ba into googleapis:master Jun 19, 2018
@ofrobots ofrobots deleted the test-10 branch June 19, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants