Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with make netstandard on Ubuntu 16.04 #635

Closed
flashfm opened this issue Mar 29, 2018 · 2 comments
Closed

Issues with make netstandard on Ubuntu 16.04 #635

flashfm opened this issue Mar 29, 2018 · 2 comments
Assignees
Labels
Bug Lang: .NET .Net wrapper issue
Milestone

Comments

@flashfm
Copy link

flashfm commented Mar 29, 2018

Hi,
I found 2 issues preventing make netstandard working on Ubuntu 16.04:

  1. tools/netstandard/CreateSigningKey/Program.cs cannot be compiled
  2. Makefile.csharp.mk line
@echo [assembly: AssemblyKeyFile("$(notdir $(CLR_KEYFILE))")] >> $(NETSTANDARD_OBJ_DIR)$SAssemblyInfo.cs 

is wrong because of quote char, I had to add additional quotes and escape the inner quotes.

It seems that pull request #586 targets these issues in particular, as well as #634

@Mizux Mizux self-assigned this Apr 3, 2018
@Mizux Mizux added Bug Lang: .NET .Net wrapper issue labels Apr 3, 2018
@Mizux Mizux added this to the v6.8 milestone Apr 3, 2018
@Mizux Mizux modified the milestones: v6.8, v6.9 Apr 26, 2018
@Mizux Mizux modified the milestones: v6.9, v6.8 Jun 20, 2018
@Mizux
Copy link
Collaborator

Mizux commented Jun 20, 2018

#668 Will provide lot of change, should test and fix it once it is integrated.
I.e. we are moving to dotnet first instead of mono

@Mizux
Copy link
Collaborator

Mizux commented Jul 25, 2018

using .Net Core SDK 2.1.302 it seems that CreateSigningKey works on all targeted platform (cf tools/docker/*)

There was issue on unix concerning the resolution of CurrentWorkingDirectory() when targeting netcoreapp2.0
cf: issues dotnet/cli#9073, dotnet/cli#9319 and the fix dotnet/cli#9504 when targeting netcoreapp2.1 available with .Net Core SDK >= 2.1.302

@Mizux Mizux closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Lang: .NET .Net wrapper issue
Projects
None yet
Development

No branches or pull requests

2 participants