Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide separate Examples NuGet Packaging #760

Closed
mwpowellhtx opened this issue Jul 16, 2018 · 6 comments
Closed

Provide separate Examples NuGet Packaging #760

mwpowellhtx opened this issue Jul 16, 2018 · 6 comments
Assignees
Labels
Feature Request Missing Feature/Wrapper Lang: .NET .Net wrapper issue
Milestone

Comments

@mwpowellhtx
Copy link
Contributor

Hello, I think this would be helpful to accelerate delivery of especially prerelease, RC, if not production, bits, especially with and taking nothing away from the the breadth of helpful illustrative examples. For instance, google.ortools.examples.$(semver).nupkg, with appropriate dependencies on the google.ortools.$(semver).nupkg. For instance if we could draw from those RCs from, say, an AppVeyor style staging area. Thanks!

@Mizux Mizux added this to the v6.9 milestone Jul 17, 2018
@Mizux Mizux added Feature Request Missing Feature/Wrapper Lang: .NET .Net wrapper issue labels Jul 17, 2018
@Mizux Mizux self-assigned this Jul 17, 2018
@Mizux
Copy link
Collaborator

Mizux commented Aug 7, 2018

I agree UnitTest and Examples shouldn't be part of the Google.OrTools.nupkg.

However, since usually for examples you want the source code to study them, I prefer to deliver them as an archive (better will be to have a separate repo like https://github.com/Microsoft/dotnet-samples) where all example are provided with a .csproj and depend on Google.OrTools package.

note: Need to leverage on the use of DEVPATH
note2: currently our examples are also used as unit tests and are needed for make test_dotnet 😞

@mwpowellhtx
Copy link
Contributor Author

@Mizux 👍 Even better.

@Mizux
Copy link
Collaborator

Mizux commented Aug 31, 2018

Since the dotnet refactor:

  • make dotnet won't build examples, sat_samples, unit tests...
    • Google.OrTools.nupkg doesn't contains/depends on examples...
  • make test_dotnet depends on test_dotnet_samples (40s) test_dotnet_csharp test_dotnet_fsharp and test_dotnet_examples (480s)
  • examples/test use a PackageReference on Google.OrTools and set <RestoreSources>../../packages;... to use the source package when building
    • note: ProjectReference doesn't work since Google.OrTools is a meta-package

@Mizux Mizux closed this as completed Aug 31, 2018
@mwpowellhtx
Copy link
Contributor Author

@Mizux To be clear, the base package should not depend on anything examples. The references would be hopelessly circular then. I think that's what you are driving at here, but I just wanted to clarify.

Otherwise, looking forward to at least test driving a pre-release package source. If not an official NuGet release.

@mwpowellhtx
Copy link
Contributor Author

@Mizux Just following up; if we can see the evaluation or beta packages land in a permanent or semi-permanent package source, that would be best, I think. I think Appveyor may support at least a limited life cycle availability, for instance. I can just add that among my package sources for evaluation purposes. Thanks again!

@Mizux
Copy link
Collaborator

Mizux commented Sep 7, 2018

Hi,
Sorry for the delay, following https://www.appveyor.com/docs/packaging-artifacts/ I'm trying to enable artifact on https://ci.appveyor.com/project/Mizux/or-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Missing Feature/Wrapper Lang: .NET .Net wrapper issue
Projects
None yet
Development

No branches or pull requests

2 participants