-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static TLS Configuration Store Library Implementation #18
Conversation
e0e9002
to
483ecf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Riya! It's looking great! Left a handful of mostly-minor comments. Should be good to go after that.
483ecf4
to
81bab25
Compare
Thanks for the review Matt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass, will do another one after all changes are in, thanks!
|
81bab25
to
ad41d67
Compare
Thanks for the comments! addressed them all in the latest push to this branch, let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor nits.
Thanks for the PR Riya!
ad41d67
to
5877cec
Compare
5877cec
to
727a2d7
Compare
This PR is a static implementation of the TLS Configuration Store Library. No calls to S2A are made.
A note on tls_config_store_test.go