From c5af8feacf87b50195f483bb3d9b5feac905278b Mon Sep 17 00:00:00 2001 From: frazar <914950+frazar@users.noreply.github.com> Date: Tue, 11 Oct 2022 00:11:42 +0200 Subject: [PATCH] Re-enable test_new_error() for i686 target (#42) The test_new_error() test was disabled for i686 due to Issue #21. This issue has since been fixed in #28, but the test was not re-enabled. --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d2f3d734c..fb91526242 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,8 +95,7 @@ jobs: # Skip the `ui` test since it invokes the compiler, which we can't do from # Miri (and wouldn't want to do anyway). # - # TODO(#21): Fix `test_new_error` on i686 and re-enable it here. - run: cargo +${{ matrix.channel }} miri test --target ${{ matrix.target }} --features "${{ matrix.features }}" -- --skip ui ${{ contains(matrix.target, 'i686') && '--skip test_new_error' || '' }} + run: cargo +${{ matrix.channel }} miri test --target ${{ matrix.target }} --features "${{ matrix.features }}" -- --skip ui # Only nightly has a working Miri, so we skip installing on all other # toolchains. #