Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All code examples should rethrow the exception it catches #168

Closed
AnashOommen opened this issue Mar 27, 2020 · 2 comments
Closed

All code examples should rethrow the exception it catches #168

AnashOommen opened this issue Mar 27, 2020 · 2 comments
Assignees
@AnashOommen
Labels
bug Something isn't working maintenance This issue is related to long term maintenance. P2

Comments

@AnashOommen
Copy link
Member

Right now, we do a catch-and-print approach for errors, which causes the test cases to pass even in a broken example, because they expect that a GoogleAdsException will be thrown.
@AnashOommen AnashOommen added bug Something isn't working P2 maintenance This issue is related to long term maintenance. labels Mar 27, 2020
@AnashOommen AnashOommen self-assigned this Mar 27, 2020
@AnashOommen
Copy link
Member Author

Fixed in #169

@AnashOommen
Copy link
Member Author

Fixed in v2.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnashOommen AnashOommen

Labels
bug Something isn't working maintenance This issue is related to long term maintenance. P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnashOommen