Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleAdsConfig implementation is too tied to ConfigurationManager #27

Closed
VitalyDukhota opened this issue Dec 14, 2018 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@VitalyDukhota
Copy link

Current GoogleAdsConfig implementation is tied to ConfigurationManager, which is only used by .NET Framework for desktop programs. .NET Web applications, and specifically .NET Core applications use WebConfigurationManager which the current implementation of GoogleAdsConfig ignores, and so it doesn't pick up configuration from it. It's not a big deal because there is LoadConfigRoot(IConfigurationRoot configurationRoot) mentioned above, which allows loading configuration from anywhere - but it requires a bit of custom coding. Perhaps having a public constructor which takes a Dictionary or similar would be nice for cases when IConfiguration is not available.

@AnashOommen
Copy link
Member

I can add a check to support WebConfigurationManager in hosted environments, but I couldn't find this in .NET Core, only in .NET SDK. Which Nuget package am I missing for .NET Core?

@AnashOommen
Copy link
Member

Fixed in v0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants