Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for bidModifier in examples #58

Closed
dklimkin opened this issue Jul 24, 2014 · 2 comments
Closed

Better handling for bidModifier in examples #58

dklimkin opened this issue Jul 24, 2014 · 2 comments
Assignees
Labels

Comments

@dklimkin
Copy link
Contributor

Logging based on:

https://groups.google.com/forum/#!msg/adwords-api/pOxbk6fzZMU/Ltd9Ote_pywJ

$value = 'none';
if (!empty($modifier->bidModifier)) {
   $value = $modifier->bidModifier;
}

There should be used is_numeric instead of !empty, since 0.0 looks like empty, but it's actually -100%, and that should be treated as well.

@saturnism saturnism self-assigned this Jul 25, 2014
@saturnism saturnism added the bug label Sep 22, 2014
@vtsao vtsao assigned vtsao and unassigned saturnism Nov 17, 2014
@vtsao
Copy link
Contributor

vtsao commented Nov 17, 2014

This will be fixed in the next release. Will ping here when it's out.

@vtsao
Copy link
Contributor

vtsao commented Dec 9, 2014

Fixed in 6.7.0 release.

@vtsao vtsao closed this as completed Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants