Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code with goimport prior to putting it in assembly target #1259

Open
codyoss opened this issue Mar 13, 2023 · 1 comment
Open

Format code with goimport prior to putting it in assembly target #1259

codyoss opened this issue Mar 13, 2023 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@codyoss
Copy link
Member

codyoss commented Mar 13, 2023 •
edited
Loading

We have a handful of diffs at the proto and gapic layer that are produced by running goimports on the code. It would be nice if we could run the tool in a starlark rule so that when code is copied by owlbot it is a much cleaner diff

googleapis/google-cloud-go@34b55fc#diff-01bc0255a405f400a4b06195ac0925d1d62bd0e99f98dee773c1541ed1a8d725L25
@codyoss codyoss added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 13, 2023
@codyoss
Copy link
Member Author

codyoss commented Mar 13, 2023

We could also consider using go/format for gapic level code to reduce diffs in files like doc.go in the example above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codyoss