Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx Warning with Gapic Generator version 0.53.4 - bullet list ends without a blank line #1064

Closed
parthea opened this issue Nov 3, 2021 · 2 comments · Fixed by #1071
Closed

Sphinx Warning with Gapic Generator version 0.53.4 - bullet list ends without a blank line #1064

parthea opened this issue Nov 3, 2021 · 2 comments · Fixed by #1071
Assignees
@busunkim96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Nov 3, 2021

This PR which includes changes from gapic generator version 0.53.4 is failing due to a docstring formatting issue.

The error is

/usr/local/google/home/partheniou/git/python-video-transcoder/google/cloud/video/transcoder_v1/types/resources.py:docstring of google.cloud.video.transcoder_v1.types.resources.Job:47:Bullet list ends without a blank line; unexpected unindent.

The. issue is resolved if I add a blank line above this line in the generated code and corresponding line in v1beta1.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 3, 2021
@parthea parthea mentioned this issue Nov 3, 2021
Merged
1 task
@parthea
Copy link
Contributor Author

parthea commented Nov 3, 2021

The issue also exists in the generated code for datacatalog here.

This was referenced Nov 3, 2021
Merged
Merged
@parthea
Copy link
Contributor Author

parthea commented Nov 3, 2021 •
edited
Loading

The issue also exists in the generated code for translation here.

@busunkim96 busunkim96 self-assigned this Nov 3, 2021
@busunkim96 busunkim96 mentioned this issue Nov 4, 2021
Merged
@parthea parthea mentioned this issue Nov 8, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: leave a newline between field description and oneof line googleapis/gapic-generator-python
2 participants
@parthea @busunkim96