Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add __version__ in GAPIC clients #1350

Merged
merged 40 commits into from
Oct 16, 2022
Merged

feat: add __version__ in GAPIC clients #1350

merged 40 commits into from
Oct 16, 2022

Conversation

galz10
Copy link
Contributor

@galz10 galz10 commented Jul 14, 2022 •
edited by parthea
Loading

This PR adds a version module to allow users to query the version of the GAPIC.

(py39) partheniou@partheniou-vm-2:~/git/python-access-approval$ python3
Python 3.10.7 (main, Sep  8 2022, 14:34:29) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.cloud.accessapproval
>>> google.cloud.accessapproval.__version__
'0.1.0'

@galz10 galz10 requested review from a team as code owners July 14, 2022 00:26
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 14, 2022
@galz10 galz10 changed the title Chore: update setup.py to new standards Chore: update setup.py template Jul 14, 2022
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@galz10 galz10 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 20, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 22, 2022
@galz10 galz10 requested a review from parthea July 22, 2022 17:51
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2022
@galz10 galz10 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 29, 2022
@galz10 galz10 added owlbot:run Add this label to trigger the Owlbot post processor. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@parthea parthea changed the title Chore: update setup.py template feat: add __version__ in GAPIC clients Oct 16, 2022
parthea
parthea approved these changes Oct 16, 2022
View reviewed changes
tests/integration/goldens/redis/setup.py Outdated Show resolved Hide resolved
tests/integration/goldens/redis/setup.py Outdated Show resolved Hide resolved
@parthea parthea merged commit 1c91347 into googleapis:main Oct 16, 2022
@release-please release-please bot mentioned this pull request Oct 16, 2022
Closed
@parthea parthea mentioned this pull request Oct 17, 2022
Merged
@parthea parthea added the release-please:force-run To run release-please label Oct 17, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 17, 2022
@parthea parthea added the release-please:force-run To run release-please label Oct 17, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 17, 2022
@release-please release-please bot mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galz10 @parthea