Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve some Showcase test errors #1353

Merged
merged 6 commits into from
Sep 2, 2023
Merged

fix: Resolve some Showcase test errors #1353

merged 6 commits into from
Sep 2, 2023

Conversation

vchudnov-g
Copy link
Contributor

This changes the code to expect the correct exceptions

@vchudnov-g vchudnov-g requested review from a team as code owners July 15, 2022 18:47
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 15, 2022
@vchudnov-g vchudnov-g force-pushed the work-with-showcase branch from c571601 to dd95cb0 Compare July 20, 2022 21:02
vam-google
vam-google approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@vchudnov-g vchudnov-g added owlbot:run Add this label to trigger the Owlbot post processor. owlbot: run labels Aug 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2022
@vchudnov-g vchudnov-g added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2022
@vchudnov-g vchudnov-g added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2022
@parthea parthea requested a review from a team as a code owner September 2, 2023 10:12
parthea
parthea approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one observation regarding the code comment

tests/system/test_retry.py Outdated Show resolved Hide resolved
@parthea parthea enabled auto-merge (squash) September 2, 2023 10:17
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2023
@parthea parthea merged commit 4eee261 into googleapis:main Sep 2, 2023
@release-please release-please bot mentioned this pull request Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchudnov-g @parthea @vam-google