fix: snippetgen handling of repeated enum field #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizcology
force-pushed
the
snippetgen-repeated-enum
branch
from
54f481a to
88b22c2
Compare
dizcology
force-pushed
the
snippetgen-repeated-enum
branch
from
88b22c2 to
fda8879
Compare
parthea
approved these changes
Oct 25, 2022
dizcology
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippetgen samples currently does not handle repeated enum fields correctly. Example: https://cloud.google.com/python/docs/reference/webrisk/latest/google.cloud.webrisk_v1.services.web_risk_service.WebRiskServiceClient#google_cloud_webrisk_v1_services_web_risk_service_WebRiskServiceClient_search_uris
(Where
threat_typesshould be a list of enums or enum name strings.)