Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add supported dict typing for client_options #1464

Merged
merged 7 commits into from
Oct 17, 2022
Merged

fix: Add supported dict typing for client_options #1464

merged 7 commits into from
Oct 17, 2022

Conversation

PicardParis
Copy link
Contributor

Fixes #1380

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 30, 2022
@PicardParis
Copy link
Contributor Author

Hi @parthea,
Remade this simple PR first.
Can you launch the tests & review?

@PicardParis PicardParis marked this pull request as ready for review September 30, 2022 13:26
@PicardParis PicardParis requested review from a team as code owners September 30, 2022 13:26
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 30, 2022
@PicardParis
Copy link
Contributor Author

@parthea, can you relaunch the tests? (not available on my side)

@PicardParis
Copy link
Contributor Author

Thanks @parthea!
This now shows 43/44 checks OK
How is the missing OwlBot Post Processor triggered?

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@PicardParis PicardParis requested a review from parthea October 7, 2022 14:21
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2022
@PicardParis PicardParis requested a review from parthea October 17, 2022 11:54
@PicardParis
Copy link
Contributor Author

  • Sync'ed with the main branch.
  • Auto-tests are ok.
  • OwlBot Post Processor to be launched manually.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit de62f12 into googleapis:main Oct 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
This was referenced Oct 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dictionary support not reflected in type annotations
2 participants
@PicardParis @parthea