-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add typing to proto.Message based class attributes #1474
Conversation
Here is the rationale for the latest changes:
|
I'm going to close and re-open this PR to re-trigger gh actions. |
...fixing conflicts due to updates in the main branch... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated the code locally for datastore and the mypy test failed with these changes.
See generated code here: https://github.com/googleapis/python-datastore/compare/test-local-gapic?expand=1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1379