fix: snippetgen should call await on the operation coroutine before calling result #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizcology
force-pushed
the
snippetgen-fix-async-lro
branch
from
28ffc51 to
cc6a6ca
Compare
dizcology
commented
Nov 15, 2022
| @@ -239,7 +239,7 @@ async def sample_export_assets(): | |||
|
|
|||
There was a problem hiding this comment.
An alternative is to change the line above to the following (add await before the method call):
operation = await client.export_assets(request=request)
gcf-owl-bot
bot
removed
the
owlbot:run
dizcology
changed the title
parthea
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated snippet contains the following code for async client that returns a long running operation, such as Vision API's
import_product_sets:This is incorrect since
operationis a coroutine that needs to beawaited to return an actual operation (which has theresultattribute).The proposed fix is to change the generated code to: