New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve unit test failure caused by differences in protobuf runtimes #1749

Merged

parthea merged 35 commits into main from add-fragment-test-service-config

Oct 7, 2023

Contributor

parthea commented Aug 29, 2023 •

edited

Loading

This PR adds a fragment test which re-creates the issue described in #1748 . The fix was applied in 77da39a

Fixes #1748 🦕
Fixes #1750 🦕

Only google/api/servicemanagement/v1 has a failing test because this is the only api which has field with type google.protobuf.Type via the google.api.Service message.

See the return type google.api.Service here :
https://github.com/googleapis/googleapis/blob/bc3c83b41b1589cca21f713a500f179ef86a7e18/google/api/servicemanagement/v1/servicemanager.proto#L158

See the message google.api.Service here which contains google.protobuf.Type:
https://github.com/googleapis/googleapis/blob/bc3c83b41b1589cca21f713a500f179ef86a7e18/google/api/service.proto#L80


          fix: resolve unit test failure

5e81e33

product-auto-label bot added the size: xl label

parthea changed the title ~~fix: resolve unit test failure~~ fix: resolve unit test failure caused by differences in protobuf runtimes

parthea commented

View reviewed changes

setup.py Show resolved Hide resolved

parthea added 4 commits

August 30, 2023 15:04


          update comment

053a39d


          add comment

639fe5e


          Only use the constraints file for standard templates

e067764


          fix generated ads tests similar to 1c4de67

8a374e6

parthea mentioned this pull request

Generated unit tests in ads templates fail with AttributeError: to_json #1750

Closed

parthea added 2 commits

August 30, 2023 16:00


          workaround issue in test where protobuf runtime version may be older

77da39a


          update goldens

f49a32c

parthea marked this pull request as ready for review

August 30, 2023 16:09

parthea requested a review from a team as a code owner

August 30, 2023 16:09

parthea added the owlbot:run label

gcf-owl-bot bot removed the owlbot:run label

parthea assigned vchudnov-g and ohmayr

parthea added 4 commits

August 31, 2023 18:34


          address offline review feedback

538710f


          update goldens

d9b85fc


          make the solution generic

b405a20


          fix grammar

1dea577

parthea unassigned ohmayr

parthea mentioned this pull request

Create a module in the generated GAPIC which can generate a sample request #1770

Open


          Merge branch 'main' into add-fragment-test-service-config

80eb916

parthea added the owlbot:run label

gcf-owl-bot bot removed the owlbot:run label

vchudnov-g reviewed

View reviewed changes

Contributor

vchudnov-g left a comment

I think this is looking OK, but I have some questions as this is my first time digging into these tests.

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

setup.py Show resolved Hide resolved

tests/fragments/google/api/auth.proto Outdated Show resolved Hide resolved

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Show resolved Hide resolved

parthea and others added 2 commits

September 19, 2023 12:08


          update comment

6ec252e

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>


          typo

9c5c4a8

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

parthea mentioned this pull request

chore: Update gapic-generator-python to v1.11.9 googleapis/python-service-management#202

Merged

1 task


          address review feedback

b52bfc5

vchudnov-g reviewed

View reviewed changes

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

tests/fragments/google/api/auth.proto Outdated Show resolved Hide resolved


          update comment

1d7f628

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

parthea assigned parthea and unassigned vchudnov-g

parthea added 2 commits

October 2, 2023 21:31


          Address review feedback

dc7934d


          add lightweight fragment test

f3b4d8e

product-auto-label bot added size: l and removed size: xl labels

parthea added 5 commits

October 5, 2023 20:31


          remove heavyweight test


          Merge branch 'main' into add-fragment-test-service-config

83fccab


          update test to cater for proto-plus message types

bcf9652


          cater for subsequent items in repeated fields

b3d6dfa


          remove new line

ed64d30

vchudnov-g approved these changes

View reviewed changes

Contributor

vchudnov-g left a comment

Please do address the comments I left. They're mostly minor, except for the one manually verifying that the simpler test really does fail without your fixes. And a question about the Ads template.

WORKSPACE Outdated Show resolved Hide resolved

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

tests/integration/goldens/redis/tests/unit/gapic/redis_v1/test_cloud_redis.py Show resolved Hide resolved

tests/integration/goldens/redis/tests/unit/gapic/redis_v1/test_cloud_redis.py Outdated Show resolved Hide resolved

tests/integration/goldens/redis/tests/unit/gapic/redis_v1/test_cloud_redis.py Show resolved Hide resolved

noxfile.py Outdated Show resolved Hide resolved

gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2 Outdated Show resolved Hide resolved

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated Show resolved Hide resolved

noxfile.py Outdated Show resolved Hide resolved

tests/fragments/test_google_protobuf_type.proto Show resolved Hide resolved

parthea and others added 7 commits

October 6, 2023 19:43


          revert WORKSPACE

ff55725


          Update comment

91404e6

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>


          update comment

f9be1b4

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>


          address review feedback

b7fc321


          address review feedback

402fb17


          update comment

ae23824

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>


          address review feedback

350006c

product-auto-label bot added size: xl and removed size: l labels

parthea added 2 commits

October 7, 2023 01:15


          update test in ads-templates

e689b13


          add comment

2a7f516

parthea enabled auto-merge (squash)

October 7, 2023 01:27

parthea merged commit 812abce into main

52 checks passed

parthea deleted the add-fragment-test-service-config branch

October 7, 2023 01:29

release-please bot mentioned this pull request

chore(main): release 1.11.6 #1758

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels