Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error for compute client(s) tests #2014

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Apr 23, 2024

Fixes #2013 🦕

@ohmayr ohmayr requested a review from a team as a code owner April 23, 2024 13:51
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 23, 2024
@ohmayr ohmayr marked this pull request as draft April 23, 2024 13:55
@ohmayr ohmayr force-pushed the fix-for-async-performance branch from d8a824b to bf82a42 Compare April 23, 2024 15:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 23, 2024
@ohmayr ohmayr force-pushed the fix-for-async-performance branch from bf82a42 to 6191526 Compare April 23, 2024 16:14
@ohmayr ohmayr marked this pull request as ready for review April 23, 2024 16:17
@ohmayr ohmayr assigned parthea and unassigned vchudnov-g Apr 23, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 23, 2024
@parthea parthea changed the title fix: type error for compute client(s) fix: type error for compute client(s) tests Apr 26, 2024
@parthea parthea merged commit 61f50f7 into main Apr 26, 2024
67 checks passed
@parthea parthea deleted the fix-for-async-performance branch April 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated unit tests for google-cloud-compute failed with gapic-generator 1.17.0
3 participants