Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate dependencies in setup.py #422

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

busunkim96
Copy link
Contributor

google-auth, googleapis-common-protos, and grpcio are required by google-api-core.

https://github.com/googleapis/python-api-core/blob/335c1097b4d697f93ed1088c581981850a66239e/setup.py#L32-L45

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #422   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1451      1451           
  Branches       300       300           
=========================================
  Hits          1451      1451           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4829a5...083e32d. Read the comment docs.

@software-dov software-dov merged commit 10403bb into master May 26, 2020
@busunkim96 busunkim96 deleted the dependencies branch June 4, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants