fix: handle repeated fields in method signatures [gg-python] #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
miraleung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1525 1525
Branches 309 309
=========================================
Hits 1525 1525 Continue to review full report at Codecov.
|
|
Change looks good, but I would be more comfortable approving the change if there were a repeated, flattened field in showcase to test against. |
|
SGTM, we can wait for a showcase test. |
software-dov
approved these changes
Sep 25, 2020
miraleung
changed the title
miraleung
changed the title
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413. Tested this locally with a proto like the one in #410 (although this doesn't solve the other, non-repeated error in that issue). There don't seem to be applicable unit tests, but please let me know if there are and I can add more.