Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only require dataclases if python<3.7 #475

Merged
merged 9 commits into from
Jun 23, 2020
Merged

fix: only require dataclases if python<3.7 #475

merged 9 commits into from
Jun 23, 2020

Conversation

busunkim96
Copy link
Contributor

The dataclasses package now only supports 3.6, which creates some weirdness with the requirements.txt requiring 0.7.0.

@busunkim96 busunkim96 requested a review from software-dov June 19, 2020 21:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2020
@busunkim96 busunkim96 changed the title fix: explicitly require 3.7+ fix: only require dataclases if python<3.7 Jun 19, 2020
requirements.txt Outdated
@@ -1,9 +1,9 @@
click==7.1.2
google-api-core==1.20.1
google-api-core==1.21.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is showing up in the diff, but this is already 1.21.0 in master.

google-api-core==1.21.0

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #475   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1466      1466           
  Branches       300       300           
=========================================
  Hits          1466      1466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed244b3...bd190f4. Read the comment docs.

requirements.txt Outdated
dataclasses==0.7; python_version < '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.6 instead, otherwise it will fail bazel build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ Fixed!

@busunkim96 busunkim96 requested a review from vam-google June 22, 2020 17:56
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please verify that bazel rules work with this.

dataclasses==0.6; python_version < '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming this syntax is understood by bazel python rules properly (the python_version < '3.7' part). Note, requirements.txt is currently used only by bazel.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently it does not :( (or something else is wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants