Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource helper methods for resources referenced in response messages #624

Closed
software-dov opened this issue Sep 29, 2020 · 0 comments · Fixed by #629
Closed

Add resource helper methods for resources referenced in response messages #624

software-dov opened this issue Sep 29, 2020 · 0 comments · Fixed by #629
Assignees
@software-dov
Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@software-dov
Copy link
Contributor

In Secret Manager, the SecretVersion resource is never referenced directly in a request by type, only in responses. This means that under the current generator logic, no service derives resource helper methods for it.

The fix is to have services also consider (recursive) response types for determining resource helper methods to generate.
@software-dov software-dov added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. generator Bugs, features, and so forth pertaining to the generated client surface labels Sep 29, 2020
@software-dov software-dov mentioned this issue Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resource messages in method response types generate helpers software-dov/gapic-generator-python
1 participant
@software-dov