fix: fix rest transport unit test and required query prams handling #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Jul 12, 2021
| @@ -196,23 +198,17 @@ class {{ service.name }}RestTransport({{ service.name }}Transport): | |||
| if {{ method.input.ident }}.{{ field }} in request: | |||
| query_params['{{ field|camel_case }}'] = request.{{ field }} | |||
| {% else %} | |||
| if request.{{ field }}: | |||
| query_params['{{ field|camel_case }}'] = request.{{ field }} | |||
| query_params['{{ field|camel_case }}'] = request.{{ field }} | |||
There was a problem hiding this comment.
Is passing empty values no longer a concern? #868
There was a problem hiding this comment.
Kind of. I have hard feelings about it. First - this is possible only for required fields, which are not common. For the requried fields, they are required to be set, and if somebody set them to empty value, then, supposedly, they know what they are doing.
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.