Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep GoogleUtils #1467

Merged
merged 3 commits into from
Jan 12, 2020
Merged

keep GoogleUtils #1467

merged 3 commits into from
Jan 12, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 8, 2020

@elharo elharo requested a review from chingor13 January 8, 2020 22:36
@elharo elharo requested a review from a team as a code owner January 8, 2020 22:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@elharo
Copy link
Contributor Author

elharo commented Jan 9, 2020

so why did this pass locally?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project google-api-client: Compilation failure: Compilation failure:
[ERROR] /tmpfs/src/github/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUtils.java:[17,26] error: package androidx.annotation does not exist
[ERROR] /tmpfs/src/github/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUtils.java:[34,1] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]

@elharo elharo mentioned this pull request Jan 11, 2020
Merged
@elharo
Copy link
Contributor Author

elharo commented Jan 11, 2020

Ping

@elharo elharo merged commit b70e8ef into master Jan 12, 2020
@elharo elharo deleted the keep branch January 12, 2020 20:43
@yoshi-automation yoshi-automation mentioned this pull request Feb 1, 2020
Merged
@worpet worpet mentioned this pull request Feb 3, 2020
Closed
chingor13 added a commit to chingor13/google-api-java-client that referenced this pull request Feb 10, 2020
@chingor13
revert: keep GoogleUtils (googleapis#1467)
6f7055e 
This reverts commit b70e8ef.
anuraaga added a commit to anuraaga/google-api-java-client that referenced this pull request Feb 14, 2020
@anuraaga
Revert "keep GoogleUtils (googleapis#1467)"
115556d 
This reverts commit b70e8ef.
elharo pushed a commit that referenced this pull request Feb 14, 2020
@anuraaga
fix: use embedded Proguard configuration instead of compile-time anno…
8a59ed0 
…tation (#1491)

* Revert "keep GoogleUtils (#1467)"

This reverts commit b70e8ef.

* Add proguard resource file to ensure GoogleUtils is kept for Android users.

* Revert "Add google android repository to Gradle instructions (#1489)"

This reverts commit 57a7bb7.

* Restore README
gcf-owl-bot bot added a commit that referenced this pull request Jun 27, 2022
@gcf-owl-bot
chore: update dependencies for regapic (#1467)
87045aa 
* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 27, 2022
@gcf-owl-bot
chore: update dependencies for regapic (#1467) (#2097)
1dc73a9 
* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
@gcf-owl-bot @blakeli0
chore: update dependencies for regapic (#1467) (#2097)
477b88c 
* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
@gcf-owl-bot @blakeli0
chore: update dependencies for regapic (#1467) (#2097)
dbd8067 
* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initializing MyApi using builder giver Exception
3 participants
@elharo @codyoss @googlebot