deps: update http client #1482
Merged
deps: update http client #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
suztomo
approved these changes
Jan 28, 2020
| assertEquals(expectedOutput, out.toString("UTF-8")); | ||
| String actual = out.toString("UTF-8"); | ||
| assertTrue(actual + "\n does not contain \n" + part1, actual.contains(part1)); | ||
| assertTrue(actual.contains(part2)); |
There was a problem hiding this comment.
Would you add source code comment what is in-between part1 and part2?
stephaniewang526
approved these changes
Jan 31, 2020
chingor13
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chingor13 @suztomo This one require test changes and was too complex for renovabot to handle