fix: use embedded Proguard configuration instead of compile-time annotation #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
anuraaga
changed the title
anuraaga
changed the title
|
/cc @JakeWharton mainly since your tweet helped me out a lot :) |
elharo
reviewed
Feb 14, 2020
elharo
reviewed
Feb 14, 2020
README.md
Outdated
| @@ -45,7 +45,6 @@ To use Gradle, add the following lines to your build.gradle file: | |||
| ```gradle | |||
| repositories { | |||
| mavenCentral() | |||
| google() | |||
There was a problem hiding this comment.
we probably want to leave this here until we're ready to release 1.30.9
There was a problem hiding this comment.
Ah yeah - reverted!
|
Not sure of versions - I don't see any reason for Android API level to be affected since this is purely compilation but there might be an SDK tooling implication. @JakeWharton do you happen to know? |
kokoro-team
removed
the
kokoro:run
|
I can at least confirm that it won't impact Android OS versions, but I don't know if this works when not compiling with R8. |
elharo
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R8 provides a mechanism for embedding proguard files, which obviates the need for a compile-time dependency on an Android library in core.
Not well documented but reasonably commonly used.
https://twitter.com/jakewharton/status/1004401938467876865?lang=en
https://github.com/square/retrofit/blob/master/retrofit/src/main/resources/META-INF/proguard/retrofit2.pro
Unfortunately, without a regression test I'm not 100% sure this works, nor am I an Android developer with much confidence, just following the pattern of other libraries :)
Fixes #1487