-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove deprecated OOB flow #2242
Conversation
Also remove `google-api-client-java6` module which is empty after removal of `GooglePromptReceiver.java`.
* href="https://developers.google.com/identity/protocols/OAuth2InstalledApp">Using OAuth 2.0 for | ||
* Mobile & Desktop Apps</a>. | ||
*/ | ||
public static final String OOB_REDIRECT_URI = "urn:ietf:wg:oauth:2.0:oob"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clirr is complaining about removal of this constant. It wasn't deprecated before. So, is it OK to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the OOB flow will be blocked for all clients on January 31, I think it is safe to remove it. Keeping it won't prevent existing users from being broken.
That is my take, I will leave the final decision to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Neenu.
Separately, can we hav one more release with "@deprecated" annotation with a link to a document that explains alternative(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we release this documentation enhancement #2244 first before stop publishing the artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I merged your PR and will do a release before merging this and releasing again.
Also remove
google-api-client-java6
module which is empty after removal ofGooglePromptReceiver.java
.