Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated OOB flow #2242

Merged
merged 3 commits into from
Jan 26, 2023
Merged

feat: remove deprecated OOB flow #2242

merged 3 commits into from
Jan 26, 2023

Conversation

meltsufin
Copy link
Member

Also remove google-api-client-java6 module which is empty after removal of GooglePromptReceiver.java.

Also remove `google-api-client-java6` module which is empty after removal of `GooglePromptReceiver.java`.
@meltsufin meltsufin requested a review from a team as a code owner January 25, 2023 04:36
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 25, 2023
@meltsufin meltsufin requested a review from Neenu1995 January 25, 2023 04:42
* href="https://developers.google.com/identity/protocols/OAuth2InstalledApp">Using OAuth 2.0 for
* Mobile & Desktop Apps</a>.
*/
public static final String OOB_REDIRECT_URI = "urn:ietf:wg:oauth:2.0:oob";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clirr is complaining about removal of this constant. It wasn't deprecated before. So, is it OK to remove?

Copy link
Contributor

@Neenu1995 Neenu1995 Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the OOB flow will be blocked for all clients on January 31, I think it is safe to remove it. Keeping it won't prevent existing users from being broken.
That is my take, I will leave the final decision to you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Neenu.

Separately, can we hav one more release with "@deprecated" annotation with a link to a document that explains alternative(s).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we release this documentation enhancement #2244 first before stop publishing the artifact?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I merged your PR and will do a release before merging this and releasing again.

@meltsufin meltsufin requested a review from suztomo January 25, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants