Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure both refreshMargin and expirationMargin are set when using OAuth2CredentialsWithRefresh #1131

Merged
merged 2 commits into from
Jan 19, 2023
Merged

fix: ensure both refreshMargin and expirationMargin are set when using OAuth2CredentialsWithRefresh #1131

merged 2 commits into from
Jan 19, 2023

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Jan 19, 2023

Fixes b/263058140

@lsirac lsirac requested a review from a team as a code owner January 19, 2023 00:27
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 19, 2023
TimurSadykov
TimurSadykov suggested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just a comment on public properties

oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java Show resolved Hide resolved
@lsirac lsirac requested a review from TimurSadykov January 19, 2023 20:23
@lsirac lsirac merged commit 326e4a1 into googleapis:main Jan 19, 2023
@lsirac lsirac deleted the oauth2refresh branch January 19, 2023 20:30
@release-please release-please bot mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsirac @TimurSadykov