Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add code sample and test for getting an access token from an im… #1289

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: add code sample and test for getting an access token from an im… #1289

merged 2 commits into from
Oct 5, 2023

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Sep 29, 2023

…personated SA

b:302748677

Also, added a test for IdTokenFromImpersonatedCredentials() which was missing.

@irataxy irataxy requested a review from a team as a code owner September 29, 2023 22:53
@snippet-bot
Copy link

snippet-bot bot commented Sep 29, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Sep 29, 2023
@Sita04 Sita04 requested review from a team and Sita04 October 2, 2023 14:15
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anguillanneuf anguillanneuf merged commit 826ee40 into googleapis:main Oct 5, 2023
14 checks passed
@release-please release-please bot mentioned this pull request Oct 5, 2023
Merged
Sita04 added a commit that referenced this pull request Oct 5, 2023
@Sita04
Revert "feat: add code sample and test for getting an access token fr…
cdc2316 
…om an impersonated SA (#1289)"

This reverts commit 826ee40.
@Sita04 Sita04 mentioned this pull request Oct 5, 2023
Merged
Sita04 added a commit that referenced this pull request Oct 11, 2023
@Sita04
Revert "feat: add code sample and test for getting an access token fr…
2d867b0 
…om an im…" (#1299)

* Revert "feat: add code sample and test for getting an access token from an impersonated SA (#1289)"

This reverts commit 826ee40.

* fix test assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@Sita04 Sita04 Awaiting requested review from Sita04

Assignees

@anguillanneuf anguillanneuf

Labels
samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irataxy @anguillanneuf @Sita04 @yoshi-kokoro