Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange usage of Preconditions.checkNotNull #510

Closed
chingor13 opened this issue Dec 1, 2020 · 0 comments · Fixed by #539
Closed

Strange usage of Preconditions.checkNotNull #510

chingor13 opened this issue Dec 1, 2020 · 0 comments · Fixed by #539
Assignees
@elharo
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@chingor13
Copy link
Contributor

google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java

Line 157 in 3b50627

useAccessToken(Preconditions.checkNotNull(refreshAccessToken(), "new access token"));
uses Preconditions within the logic of the function rather than its standard usage as a guard clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elharo elharo

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace non-precondition use of Preconditions googleapis/google-auth-library-java
2 participants
@chingor13 @elharo