feat: update retries and implement Retryable #750

TimurSadykov · 2021-09-28T23:36:12Z

This is PR fixes retries to token endpoint.
For more details on the feature: go/auth-correct-retry

Fixes #626

…tCredentials

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…implementation

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…r text credential source (#822) * fix: remove erroneous check for the subject token field name for text format in IdentityPoolCredentialSource * fix: case insensitive * fix: null check * fix: imports

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java

credentials/java/com/google/auth/Retryable.java

oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

lesv

I need to spend a bit more time w/ your testing, but I'm generally favorable. If I didn't comment on Jeff's comment's, I probably agree with them. Even were I disagree, I'll defer to him if he insists.

ServiceAccountCredentials constructor has way too many parameters and should be made into a builder pattern - especially since your breaking any contract anyway.

I want to spend a bit more time thinking through your tests, but I believe you've implemented what I read in the design docs.

credentials/java/com/google/auth/Retryable.java

oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

…erviceAccountCredentials

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

lesv

I'm sending this early as I'm going to get lunch.

I found some stuff that you will want to change. I'm suggesting change to the form of the builder pattern that I ok'd yesterday - apologies - I should n't type on my phone. I'm ok if you don't want to do it. I'm unattached to my suggestions on names.

I'll pick up where I left off in an hour or so.

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

lesv

Ignore my earlier comments. LGTM

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

ejona86

drive-by comment

ejona86 · 2022-02-11T14:45:33Z

credentials/java/com/google/auth/Retryable.java

+
+package com.google.auth;
+
+// an interface to identify retryable errors


/** Retryable is an interface to identify retryable errors. */

feat: update retries and implement Retryable

70b01b7

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021

TimurSadykov and others added 19 commits September 29, 2021 13:28

fix: retry logic fix

b9bbc1f

feat: add RetryStrategy setting to GoogleCredential and ServiceAccoun…

11c9ffa

…tCredentials

fix: refactor retryable interface

2791b9a

Merge remote-tracking branch 'origin/main' into stim-common-retry

fd7a446

fix: javadocs

190d191

🦉 Updates from OwlBot

8c0991c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix: remove RetryStrategy

d863ce8

fix: change set definition to java 8 compatible

c6ef5c5

🦉 Updates from OwlBot

e92c65b

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feat: tests for new retries

f8d6842

🦉 Updates from OwlBot

7b4e490

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix: update method name

5aef1f7

fix: temporary poms

fc7bcb4

🦉 Updates from OwlBot

67cfaab

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix: refactor to move response handling into the specific credential …

5bd45cf

…implementation

🦉 Updates from OwlBot

7e7f437

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix: update dependencies with release builds

22b2ce5

fix: http-client dependency fix

e11b257

fix: http-client dependency fix

626cb41

TimurSadykov marked this pull request as ready for review January 7, 2022 13:34

TimurSadykov requested a review from a team as a code owner January 7, 2022 13:34

TimurSadykov requested a review from arithmetic1728 January 7, 2022 13:34

TimurSadykov and others added 6 commits January 9, 2022 18:47

remove unused dependency

e1910c2

feat: additional factory method

eef2030

feat: flag to disable default retries and tests

d7bef21

🦉 Updates from OwlBot

577bfef

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix: merge conflict

d88bc10

fix: (WIF) remove erroneous check for the subject token field name fo…

c22fb51

…r text credential source (#822) * fix: remove erroneous check for the subject token field name for text format in IdentityPoolCredentialSource * fix: case insensitive * fix: null check * fix: imports

TimurSadykov added 3 commits January 12, 2022 16:45

Merge remote-tracking branch 'origin/main' into stim-common-retry

c14a620

fix: nit remove extra ;

afb3a50

merge latest

10a0c0c

arithmetic1728 approved these changes Feb 1, 2022

View reviewed changes

TimurSadykov and others added 2 commits February 2, 2022 00:50

feat: generate retryable exceptions for UserCredentials

1adab2c

🦉 Updates from OwlBot

b533e65

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

TimurSadykov requested review from lesv and arithmetic1728 February 2, 2022 08:59

Merge branch 'main' into stim-common-retry

7404928

arithmetic1728 approved these changes Feb 2, 2022

View reviewed changes

chingor13 reviewed Feb 3, 2022

View reviewed changes

lesv suggested changes Feb 3, 2022

View reviewed changes

TimurSadykov and others added 2 commits February 4, 2022 11:28

fix: remove public from exception constructors, leverage builder in S…

4363aba

…erviceAccountCredentials

🦉 Updates from OwlBot

d309720

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

TimurSadykov requested review from arithmetic1728, lesv and chingor13 February 4, 2022 19:56

TimurSadykov commented Feb 4, 2022

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved

TimurSadykov self-assigned this Feb 4, 2022

lesv suggested changes Feb 4, 2022

View reviewed changes

lesv approved these changes Feb 4, 2022

View reviewed changes

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Show resolved Hide resolved

arithmetic1728 approved these changes Feb 4, 2022

View reviewed changes

TimurSadykov and others added 2 commits February 6, 2022 20:04

fix: update ServiceAccountCredentials docs

23d38a5

🦉 Updates from OwlBot

d85aee4

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

TimurSadykov merged commit f9a9b8a into main Feb 7, 2022

TimurSadykov deleted the stim-common-retry branch February 7, 2022 04:51

release-please bot mentioned this pull request Feb 7, 2022

chore(main): release 1.5.0 #845

Merged

ejona86 reviewed Feb 11, 2022

View reviewed changes

ejona86 mentioned this pull request Mar 31, 2022

GRPC will keep retrying (until RPC timeout) if a user uses a bad service account key grpc/grpc-java#6808

Closed

release-please bot mentioned this pull request Aug 11, 2022

chore(main): release 1.11.0 #974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update retries and implement Retryable #750

feat: update retries and implement Retryable #750

TimurSadykov commented Sep 28, 2021 •

edited

Loading

lesv left a comment

lesv left a comment

lesv left a comment

ejona86 left a comment

ejona86 Feb 11, 2022


		package com.google.auth;

		// an interface to identify retryable errors

feat: update retries and implement Retryable #750

feat: update retries and implement Retryable #750

Conversation

TimurSadykov commented Sep 28, 2021 • edited Loading

lesv left a comment

Choose a reason for hiding this comment

lesv left a comment

Choose a reason for hiding this comment

lesv left a comment

Choose a reason for hiding this comment

ejona86 left a comment

Choose a reason for hiding this comment

ejona86 Feb 11, 2022

Choose a reason for hiding this comment

TimurSadykov commented Sep 28, 2021 •

edited

Loading