Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add AWS Session Token to Metadata Requests #850

Merged
merged 8 commits into from
Feb 24, 2022
Merged

feat: Add AWS Session Token to Metadata Requests #850

merged 8 commits into from
Feb 24, 2022

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Feb 10, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes 194738780☕️

@sai-sunder-s sai-sunder-s requested a review from a team as a code owner February 10, 2022 01:55
@lsirac lsirac self-requested a review February 10, 2022 02:16
lsirac
lsirac reviewed Feb 10, 2022
View reviewed changes
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Show resolved Hide resolved
lsirac
lsirac requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@lsirac lsirac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. Thanks Sai!

oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
@TimurSadykov TimurSadykov self-requested a review February 18, 2022 23:41
@TimurSadykov TimurSadykov added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 18, 2022
@TimurSadykov
Copy link
Contributor

looking

TimurSadykov
TimurSadykov suggested changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth bits ok, just some nits and tweaks

oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/AwsCredentials.java Outdated Show resolved Hide resolved
@TimurSadykov TimurSadykov removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 19, 2022
@TimurSadykov TimurSadykov merged commit 577e9a5 into googleapis:main Feb 24, 2022
@release-please release-please bot mentioned this pull request Feb 24, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 16, 2022
@release-please
chore(main): release 1.6.0 (#877)
463ac04 
🤖 I have created a release *beep* *boop*
---


## [1.6.0](v1.5.3...v1.6.0) (2022-03-15)


### Features

* Add AWS Session Token to Metadata Requests ([#850](#850)) ([577e9a5](577e9a5))


### Bug Fixes

* ImmutableSet converted to List for Impersonated Credentials ([#732](#732)) ([7dcd549](7dcd549))
* update library docs ([#868](#868)) ([a081015](a081015))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
@aeitzman aeitzman mentioned this pull request Aug 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-sunder-s @TimurSadykov @Neenu1995 @lsirac