fix: throw on missing refresh token in all cases #670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606. In most cases, this library would throw if an attempt to refresh a token was made, and no refresh token was available. It turns out there was a loophole here if the
getRequestHeaders
method was called, and the throw would get lost in the shuffle. Instead, a call to the OAuth2 refresh endpoint would get made with an empty refresh token, leading to a less awesome exception. This change:describe
block in the test fileMake sure to hide whitespace before reviewing this one :)