Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: upgrade engines field to >=8.10.0 #686

Merged
merged 2 commits into from
May 2, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #686 into master will decrease coverage by 3.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   88.35%   84.69%   -3.66%     
==========================================
  Files          18       18              
  Lines         773      928     +155     
  Branches       84      203     +119     
==========================================
+ Hits          683      786     +103     
- Misses         79       82       +3     
- Partials       11       60      +49
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <0%> (-11.91%) ⬇️
src/auth/computeclient.ts 90.32% <0%> (-9.68%) ⬇️
src/messages.ts 83.33% <0%> (-7.15%) ⬇️
src/auth/envDetect.ts 89.28% <0%> (-6.17%) ⬇️
src/auth/googleauth.ts 86.07% <0%> (-4.98%) ⬇️
src/auth/jwtclient.ts 88.37% <0%> (-4.49%) ⬇️
src/auth/oauth2client.ts 82.55% <0%> (-3.91%) ⬇️
src/transporters.ts 89.13% <0%> (-2.98%) ⬇️
src/crypto/browser/crypto.ts 10.71% <0%> (-0.83%) ⬇️
src/auth/refreshclient.ts 88.57% <0%> (-0.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c286...08202a5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #686 into master will decrease coverage by 3.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   88.35%   84.69%   -3.66%     
==========================================
  Files          18       18              
  Lines         773      928     +155     
  Branches       84      203     +119     
==========================================
+ Hits          683      786     +103     
- Misses         79       82       +3     
- Partials       11       60      +49
Impacted Files Coverage Δ
src/crypto/crypto.ts 71.42% <0%> (-11.91%) ⬇️
src/auth/computeclient.ts 90.32% <0%> (-9.68%) ⬇️
src/messages.ts 83.33% <0%> (-7.15%) ⬇️
src/auth/envDetect.ts 89.28% <0%> (-6.17%) ⬇️
src/auth/googleauth.ts 86.07% <0%> (-4.98%) ⬇️
src/auth/jwtclient.ts 88.37% <0%> (-4.49%) ⬇️
src/auth/oauth2client.ts 82.55% <0%> (-3.91%) ⬇️
src/transporters.ts 89.13% <0%> (-2.98%) ⬇️
src/crypto/browser/crypto.ts 10.71% <0%> (-0.83%) ⬇️
src/auth/refreshclient.ts 88.57% <0%> (-0.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c286...08202a5. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 377d5c6 into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants