fix: Fixed parsing of expiration timestamp from ID tokens #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch as service accounts
dazuma
changed the title
bajajneha27
approved these changes
Oct 4, 2024
viacheslav-rostovtsev
approved these changes
Oct 4, 2024
| scopes = ["https://www.googleapis.com/auth/drive", "https://www.googleapis.com/auth/bigtable.data"] | ||
| stub = make_auth_stubs access_token: "1/abcdef1234567890", scope: scopes | ||
| @client = GCECredentials.new(scope: scopes) | ||
| @client.fetch_access_token! | ||
| expect(stub).to have_been_requested | ||
| end | ||
| end | ||
|
|
||
| describe "Fetch ID tokens" do |
There was a problem hiding this comment.
why is this a separate describe with the same name as below?
There was a problem hiding this comment.
Different context (metadata is available vs metadata is not available)
| base64 = Base64.urlsafe_decode64 match[1] | ||
| json = JSON.parse base64 rescue nil | ||
| return unless json.respond_to?(:key?) && json.key?("exp") | ||
| Time.at json["exp"].to_i |
There was a problem hiding this comment.
can this fail / does it need a rescue?
There was a problem hiding this comment.
I don't think so, but good idea to wrap it anyway for safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was never implemented, with the result that ID token credential objects stopped working when the token expired.