Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit response event from file#createReadStream() #610

Merged
merged 3 commits into from
May 20, 2015
Merged

Emit response event from file#createReadStream() #610

merged 3 commits into from
May 20, 2015

Conversation

robertdimarco
Copy link
Contributor

See #606

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2015
ryanseys
ryanseys reviewed May 19, 2015
View reviewed changes
test/storage/file.js

setImmediate(function() {
that.emit('response', fakeResponse);
that.emit('complete', fakeResponse);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ryanseys
Copy link
Contributor

Can you please document this functionality in the docs for file#createReadStream :)

@robertdimarco
Copy link
Contributor Author

@ryanseys I added a line to the file#createReadStream header docs but let me know if you'd like to see more there or there's something I need to do to autogenerate-then-commit those docs.

ryanseys added a commit that referenced this pull request May 20, 2015
@ryanseys
Merge pull request #610 from robertdimarco/rd-emit-response-event
0ba8b88 
Emit response event from file#createReadStream()
@ryanseys ryanseys merged commit 0ba8b88 into googleapis:master May 20, 2015
@ryanseys
Copy link
Contributor

Thanks @robertdimarco ! 💃

@robertdimarco robertdimarco deleted the rd-emit-response-event branch May 20, 2015 15:58
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@gcf-owl-bot
chore: disable renovate dependency dashboard (#1194) (#610)
2572825 
Source-Link: googleapis/synthtool@31728d8
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:667a9e46a9aa5b80240ad164d55ac33bc9d6780b5ef42f125a41f0ad95bc1950

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@gcf-owl-bot
feat: turns on self-signed JWT feature flag (#610)
43fb161 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 392067151

Source-Link: googleapis/googleapis@06345f7

Source-Link: googleapis/googleapis-gen@95882b3
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@release-please
chore: release 4.3.0 (#611)
f6fe045 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.3.0](https://www.github.com/googleapis/nodejs-language/compare/v4.2.9...v4.3.0) (2021-08-23)


### Features

* turns on self-signed JWT feature flag ([#610](https://www.github.com/googleapis/nodejs-language/issues/610)) ([461baca](https://www.github.com/googleapis/nodejs-language/commit/461bacad4c1c2216e39622b3f82ef634a3665956))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Oct 11, 2022
Closed
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@gcf-owl-bot @sofisl
feat: turns on self-signed JWT feature flag (#610)
90f94fd 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 392067151

Source-Link: googleapis/googleapis@06345f7

Source-Link: googleapis/googleapis-gen@95882b3
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@release-please @sofisl
chore: release 4.3.0 (#611)
90c17b2 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.3.0](https://www.github.com/googleapis/nodejs-language/compare/v4.2.9...v4.3.0) (2021-08-23)


### Features

* turns on self-signed JWT feature flag ([#610](https://www.github.com/googleapis/nodejs-language/issues/610)) ([461baca](https://www.github.com/googleapis/nodejs-language/commit/461bacad4c1c2216e39622b3f82ef634a3665956))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 9, 2022
@gcf-owl-bot
chore: disable renovate dependency dashboard (#1194) (#610)
173344a 
Source-Link: googleapis/synthtool@31728d8
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:667a9e46a9aa5b80240ad164d55ac33bc9d6780b5ef42f125a41f0ad95bc1950

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 9, 2022
Closed
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@yoshi-automation
docs: update dates (#610)
5529e7b 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/000b31a7-d841-4bba-9f39-9c136bef31bc/targets

- [ ] To automatically regenerate this PR, check this box.
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@gcf-owl-bot
fix(docs): describe fallback rest option (#610)
7fbaf70 
* feat: support regapic LRO

Use gapic-generator-typescript v2.15.1.

PiperOrigin-RevId: 456946341

Source-Link: googleapis/googleapis@88fd18d

Source-Link: googleapis/googleapis-gen@accfa37
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@release-please
chore(main): release 4.0.1 (#611)
bcf0fc7 
🤖 I have created a release *beep* *boop*
---


## [4.0.1](googleapis/nodejs-text-to-speech@v4.0.0...v4.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#610](googleapis/nodejs-text-to-speech#610)) ([26bc91a](googleapis/nodejs-text-to-speech@26bc91a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
build: do not fail builds on codecov errors (#528) (#610)
4984a5f 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets

Source-Link: googleapis/synthtool@be74d3e
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#610)
be3d07e 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
@sofisl sofisl mentioned this pull request Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@renovate-bot
chore(deps): update dependency sinon to v14 (#610)
ffdc9c3 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1400)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0)

-   [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00)
    Drop node 12 (Morgan Roderick)
    > And embrace Node 18
    >
    > See https://nodejs.org/en/about/releases/

*Released by Morgan Roderick on 2022-05-07.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-automl).
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
@takeratta takeratta mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertdimarco @ryanseys @googlebot