diff --git a/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/services/certificate_manager/client.py b/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/services/certificate_manager/client.py index 1a8ee724bfd0..2dafe1157ec0 100644 --- a/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/services/certificate_manager/client.py +++ b/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/services/certificate_manager/client.py @@ -291,20 +291,20 @@ def parse_dns_authorization_path(path: str) -> Dict[str, str]: def target_https_proxies_path( project: str, location: str, - targetHttpsProxy: str, + target_https_proxy: str, ) -> str: """Returns a fully-qualified target_https_proxies string.""" - return "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}".format( + return "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}".format( project=project, location=location, - targetHttpsProxy=targetHttpsProxy, + target_https_proxy=target_https_proxy, ) @staticmethod def parse_target_https_proxies_path(path: str) -> Dict[str, str]: """Parses a target_https_proxies path into its component segments.""" m = re.match( - r"^projects/(?P.+?)/locations/(?P.+?)/targetHttpsProxies/(?P.+?)$", + r"^projects/(?P.+?)/locations/(?P.+?)/targetHttpsProxies/(?P.+?)$", path, ) return m.groupdict() if m else {} @@ -313,20 +313,20 @@ def parse_target_https_proxies_path(path: str) -> Dict[str, str]: def target_ssl_proxies_path( project: str, location: str, - targetSslProxy: str, + target_ssl_proxy: str, ) -> str: """Returns a fully-qualified target_ssl_proxies string.""" - return "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}".format( + return "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}".format( project=project, location=location, - targetSslProxy=targetSslProxy, + target_ssl_proxy=target_ssl_proxy, ) @staticmethod def parse_target_ssl_proxies_path(path: str) -> Dict[str, str]: """Parses a target_ssl_proxies path into its component segments.""" m = re.match( - r"^projects/(?P.+?)/locations/(?P.+?)/targetSslProxies/(?P.+?)$", + r"^projects/(?P.+?)/locations/(?P.+?)/targetSslProxies/(?P.+?)$", path, ) return m.groupdict() if m else {} diff --git a/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/types/certificate_manager.py b/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/types/certificate_manager.py index 6fffbeda0a36..825a1b292080 100644 --- a/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/types/certificate_manager.py +++ b/packages/google-cloud-certificate-manager/google/cloud/certificate_manager_v1/types/certificate_manager.py @@ -849,7 +849,10 @@ class Certificate(proto.Message): san_dnsnames (Sequence[str]): Output only. The list of Subject Alternative Names of dnsName type defined in the certificate - (see RFC 5280 4.2.1.6) + (see RFC 5280 4.2.1.6). Managed certificates + that haven't been provisioned yet have this + field populated with a value of the + managed.domains field. pem_certificate (str): Output only. The PEM-encoded certificate chain. diff --git a/packages/google-cloud-certificate-manager/tests/unit/gapic/certificate_manager_v1/test_certificate_manager.py b/packages/google-cloud-certificate-manager/tests/unit/gapic/certificate_manager_v1/test_certificate_manager.py index 5b39fbd12fd5..6c0947bb9ba2 100644 --- a/packages/google-cloud-certificate-manager/tests/unit/gapic/certificate_manager_v1/test_certificate_manager.py +++ b/packages/google-cloud-certificate-manager/tests/unit/gapic/certificate_manager_v1/test_certificate_manager.py @@ -7099,14 +7099,14 @@ def test_parse_dns_authorization_path(): def test_target_https_proxies_path(): project = "whelk" location = "octopus" - targetHttpsProxy = "oyster" - expected = "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}".format( + target_https_proxy = "oyster" + expected = "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}".format( project=project, location=location, - targetHttpsProxy=targetHttpsProxy, + target_https_proxy=target_https_proxy, ) actual = CertificateManagerClient.target_https_proxies_path( - project, location, targetHttpsProxy + project, location, target_https_proxy ) assert expected == actual @@ -7115,7 +7115,7 @@ def test_parse_target_https_proxies_path(): expected = { "project": "nudibranch", "location": "cuttlefish", - "targetHttpsProxy": "mussel", + "target_https_proxy": "mussel", } path = CertificateManagerClient.target_https_proxies_path(**expected) @@ -7127,14 +7127,14 @@ def test_parse_target_https_proxies_path(): def test_target_ssl_proxies_path(): project = "winkle" location = "nautilus" - targetSslProxy = "scallop" - expected = "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}".format( + target_ssl_proxy = "scallop" + expected = "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}".format( project=project, location=location, - targetSslProxy=targetSslProxy, + target_ssl_proxy=target_ssl_proxy, ) actual = CertificateManagerClient.target_ssl_proxies_path( - project, location, targetSslProxy + project, location, target_ssl_proxy ) assert expected == actual @@ -7143,7 +7143,7 @@ def test_parse_target_ssl_proxies_path(): expected = { "project": "abalone", "location": "squid", - "targetSslProxy": "clam", + "target_ssl_proxy": "clam", } path = CertificateManagerClient.target_ssl_proxies_path(**expected)